[product icon themes] No fallback for using icon contribution point

Testing #117263

While it’s been nice to leverage custom icons from another extension:

There doesn’t seem to be a way to set a fallback in case a user does not have the custom icon extension installed:

I guess you could mark that other extension as a dependency, but that would make it harder to use and would love for an easier way. We should allow for a fallback icon that uses a codicon icon.

[aeschli]

Thanks, fixed the missing warning and validation of required properties,

[alefragnani]

Hi @aeschli ,

That’s great! It indeed does work, BUT with a few changes/limitations:

• The id cannot have . (dots)
• I must provide a description

If I use project-manager.favorites.codespaces as icon’s id, it will fail. It will display the error codicon instead. I tried a few scenarios and discovered that the . (dot character) was the reason. Yes, there is a regex to validate the icon’s id, but it does not warn about the dot character not being supported (if this is intentional).

Doing these changes, I could see it working perfectly:

"icons": [
            {
              "id": "project-manager-favorites-codespaces",
              "description": "Favorite Projects on Codespaces",
              "default": "github" 
             }
          ]

Thank you