[pug] add auto indent

• VSCode Version: 1.30.0
• OS Version: Windows 10 x64 (1803)

The auto indentation when using pug is not working. Here is an example of VSCode (1.30.0) vs Sublime Text (3.1.1) and Atom (1.33.0) showing the expected behavior:

And here a gif showing what happen in each one while typing (the tab and space keys were not used):

Steps to Reproduce:

1. Open a tab and select Pug syntax
2. Type some tags like the next example without using tab or space keys:

h1 test
.example
    ul
        li

Does this issue occur when all extensions are disabled?: Yes

Extensions enabled:

• advanced-new-file
• Bookmarks
• Bracket Pair Colorizer
• Code Spell Checker
• colorize
• Identical Sublime Monokai C# theme and colorizer
• Path Autocomplete
• Relative Path
• Sublime Text Keymap and Settings Importer

[timdmackey]

Okay, so I found a complete regex pattern for pug in the original repo that vscode’s pug extension is based on: davidrios/pug-tmbundle. This is the relevant file: /Preferences/Miscellaneous.tmPreferences

Here’s the the original regex definition for increaseIndentPattern:

(?x) # enable free-spacing and comments
^\s*(  # start with any whitespace
    ([\w#.-]+(\(.*?\))?  # first tag
    (:\s*[\w#.-]+(\(.*?\))?)*  # additional tags
    \.?$)  # end tag with . or end of line
    |(:[a-z]\w*($|\())  # filters
    |(//-?$)  # multiline comments
    |(-\s+(if|else|while)(\s+|$))  # embedded js control flow
    |((for|if|else if|else|each|until|while|unless|case|when|block|append|prepend)(\s+|$))  # pug block first-class
)

and for decreaseIndentPattern:

^\s*(- )?(else)\b.*$

and here are the reformatted regex definitions:

"indentationRules": {
    "increaseIndentPattern": "^\\s*(([\\w#.-]+(\\(.*?\\))?(:\\s*[\\w#.-]+(\\(.*?\\))?)*\\.?$)|(:[a-z]\\w*($|\\())|(\\/\\/-?$)|(-\\s+(if|else|while)(\\s+|$))|((for|if|else if|else|each|until|while|unless|case|when|block|append|prepend)(\\s+|$)))",
    "decreaseIndentPattern": "^\\s*(- )?(else)\b.*$",
    "disableIndentNextLinePattern": ""
}

I reformatted the regex pattern, removing the comments, newlines, and free-spacing mode modifier, and properly escaped everything. It appears to be working correctly based on my testing. Anyone else care to try it out?

I made a pull request with the incorporated changes: https://github.com/Microsoft/vscode/pull/66099

[timdmackey]

I made a really hacky fix for myself with the following addition to /extensions/pug/language-configuration.json:

"indentationRules": {
    "increaseIndentPattern": ".",
    "decreaseIndentPattern": "."
}

Ideally, these rules would filter for tags which are not self closing, so that if an element cannot have any children adding a newline doesn’t auto-indent.