Stuck on an issue?
Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
After checkout own PR, always returns to review mode when check out PR's working branch
See original GitHub issue- Extension version: 0.1.2
- VSCode Version: 1.27.1 (5944e81f3c46a3938a82c701f96d7a59b074cfdc, 2018-09-06T09:21:18.328Z)
- OS: Windows_NT x64 10.0.18234
Steps to Reproduce:
Assume we have a working branch named ‘feature-branch’
- Send in a (own) PR to a repo (based on branch feature-branch).
- Checkout (own) PR with extension.
- Exit Review Mode (
git checkout master) - Run
git checkout feature-branch.
Now we are in review mode again.
Issue Analytics
- State:
- Created 5 years ago
- Reactions:7
- Comments:10 (3 by maintainers)
Top Results From Across the Web
How can I fetch an unmerged pull request for a branch I don't ...
I think it's worth noting that git pull will keep you on your current branch and merge in the PR changes while git...
Read more >Lifecycle of a Pull Request - Python Developer's Guide
Review and address comments on your Pull Request. When your changes are merged, you can delete the PR branch. Celebrate contributing to CPython!...
Read more >Ability to reopen a declined pull request | Bitbucket Cloud
FIX: The fastest way now is to checkout to a new branch from "declined and fixed branch"(git checkout -b newbranchname), push it and...
Read more >Working with Pull Requests as a reviewer - Web Platform Tests
Generally, the reviewer should ask the author to make the desired changes. ... Checkout that branch: git checkout <name-of-the-PR-branch>.
Read more >Code Reviews Using the Visual Studio Pull Requests Extension
With this extension you can also: Review and checkout Pull Requests from Azure Repos; Get an inline peek to see more details about...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
There are multiple duplicate issues like this, probably one that I opened too. And this is one of the reasons I’m not using this extension after trying it.
The way “Exit Review Mode” works is confusing, it doesn’t exit review mode, it just switches branches. Meaning that once you switch back to the branch you will be in review mode again as that state in the extension is left behind.
In my opinion, it should really exit review mode, returning to the state the extension is in on startup. Switching branches being an optional convenience for the use case of checking out a branch solely for looking at its PR and not a requirement to exit review mode.
You might enter review mode from creating a PR on your own branch, or to look at comments on it to fix them, you don’t necessarily want to switch branches when done, just turn off review mode (The review gutter, etc.).
I would like to have a way to leave review mode. Now I am forced into it for a branch I switch to if it happens to be a PR too. But this PR I just created for myself, not for someone to review.
E.g. I see the review decorations now in the editor without having a way to turn that off: