Stuck on an issue?
Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Can't resolve conversations from description page
See original GitHub issue- Extension version: v.0.26.0
- VSCode Version: 1.56.2
- OS: Windows_NT x64 10.0.19042
Steps to Reproduce:
- Receive review comments on an open PR.
- Create commit to resolve comments and push.
- Go Pull Request description to close comment and see that it’s marked
Outdatedwith no option to resolve.
Resolving conversations in general was added in https://github.com/microsoft/vscode-pull-request-github/pull/2641 but I assume the interaction with Outdated commits is surfacing some thorns.
Of course, the work around is to resolve from GitHub website but my long term goal is to do everything from inside VS Code of course!
Issue Analytics
- State:
- Created 2 years ago
- Reactions:3
- Comments:7 (4 by maintainers)
Top Results From Across the Web
Can't resolve conversation from description page · Issue #2685
To be clear, you can resolve conversations, just not on the description page. And I mean github.com...
Read more >Resolvable Conversations | GitHub Changelog
Each resolved conversation indicates who resolved it. Learn more about resolving conversations · Suppression of diff contents for file deletions.
Read more >If you have an issue with Messages or FaceTime after setting ...
After setting up your iPhone, you might experience one or more of the following issues: You can't receive iMessages or FaceTime calls.
Read more >8 Ways to Get a Difficult Conversation Back on Track
Below are eight strategies David put into practice, all of which you can use to get conversations back on track and then move...
Read more >Sparkcentral resolve settings and topic requirement
Go to Admin settings, expand Agent workspace, and then select Resolve topics.Use the toggle to turn on the requirement to select a topic...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
@BenjaVR I would like to take a PR for it, but I have just taken over managing this extension so my knowledge of what direction to point you in is low right now, but here’s what I can tell you:
The comment section on the overview page is done here. I think you’d probably need to add to the
action-bar. https://github.com/microsoft/vscode-pull-request-github/blob/09386e95d87909f1717f3c330b7e6c7c427bb8ee/webviews/components/comment.tsx#L61-L86Here is how you delete a comment, which you can use as reference for resolving a comment. https://github.com/microsoft/vscode-pull-request-github/blob/9346269d520d0ecc6fdcf4fd7369ca7eb5f354e1/webviews/common/context.tsx#L72-L97
Once you have the appropriate args, you can use this to resolve: https://github.com/microsoft/vscode-pull-request-github/blob/4c6d79cb0e503f3af996d3e848a43b440f998ed4/src/commentHandlerResolver.ts#L22-L23
which I expect you would call from a new entry in this switch statement: https://github.com/microsoft/vscode-pull-request-github/blob/cda4dd3fd7dd730ea45f589c69e8c71766f5c6ca/src/github/issueOverview.ts#L187-L188
duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/2685