question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

I would not have expected that toggle the comment state will change the setting file

See original GitHub issue

Testing #2931

  • collapse all comments
  • observe: the user setting for githubPullRequests.commentExpandState changes to collapseAll

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
alexr00commented, Aug 25, 2021

Here’s what I landed on:

  • The Toggle command has been removed in favor of a Collapse command and an Expand command
  • The setting is no longer changed when you run the Expand/Collapse commands or the use the action on the comment widget.
  • The action on the comment widget is always “Collapse All Comments”.
0reactions
dbaeumercommented, Aug 25, 2021

I am not arguing against persisting the UI state across reloads but to my knowledge the UI state is persisted per workspace. This setting is a user setting and might be synced to even other machines. So clicking a minus button in the UI has a far higher impact than I would have expected.

Read more comments on GitHub >

github_iconTop Results From Across the Web

"Toggle Comments for this file" button doesn't switch state from ...
Open an MR with comments on code changes; Go to "Changes" tab ... The button should toggle active state depending on whether the...
Read more >
React setState not updating state - Stack Overflow
My problem was that setState was happening from callback func, issued by one of the components. And my suspicious is that the call...
Read more >
Change a conflicting keyboard shortcut on Mac - Apple Support
On your Mac, choose Apple menu > System settings, then click Keyboard in the sidebar.
Read more >
EditorConfig settings - Visual Studio (Windows) - Microsoft Learn
When you add an EditorConfig file to your project in Visual Studio, new lines of code are formatted based on the EditorConfig settings....
Read more >
Filing Corporate Income Tax Return and Paying Tax - Topics
Corporate income tax returns are usually filed on Form 1120, ... that do not have an office or place of business within the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found