Should github.hosts be stored in local storage?

Not sure it’s useful to have in my settings.json, can this be hidden in local storage?

  "github.hosts": [
    {
      "host": "https://github.com",
      "username": "oauth",
      "token": "system"
    }
  ]

[shana]

@Tyriar When you say it’s no longer system, do you mean you went through the sign in process and it added the entry in the settings file with system, and then sometime later it became the actual token?

Could you check your system credential manager and see if you have an entry there named vscode-pull-request-github with token in it, and whether it matches?

Having the configuration hidden away and able to be overridden by the setting file is a good idea, I’ll see what I can do.

[queerviolet]

This should be fixed by #659