Feature request: Ship isort 5

I was trying out

"python.sortImports.args": [
        "--profile",
        "black",
    ],

today, which promises better compatibility between isort and black. However, it seems that the extension ships with an older version of isort that does not support these flags.

user@host:~/.vscode-server/extensions/ms-python.python-2020.6.91350/pythonFiles/lib/python/isort> grep version __init__.py
__version__ = "4.3.21"

Even worse, adding these flags leads to endless “Saving xyz.py: Applying code action ‘Sort imports’.”

Shipping isort>=5 should solve this.

[karrtikr]

Next release will have the new isort

[PeterJCLaw]

• Remove old workaround used with isort 4: In sortImports.py, remove the following change: fc34f9c isort5 expects stdin stream to be of type string, not byte. And the workaround converts stream to bytes, so we have an error when upgrading. From my understanding, the workaround was added because of timothycrosley/isort#1195 with isort4, but isort5 doesn’t have that issue, so we can remove it. cc @PeterJCLaw

Yup, that’s correct regarding the workaround. If isort>=5 has fixed the Windows stdin issue on its own then that workaround can be dropped. (I don’t tend to develop on Windows, so haven’t tested that). It was the vscode-python CI which originally found the issue, so if the CI is happy everything should be fine.