Support detecting `bash.bat` shells correctly
See original GitHub issueEnvironment data
- VS Code version: 1.41.1
- Extension version (available under the Extensions sidebar):
- OS and version: 2020.1.58038
- Python version (& distribution if applicable, e.g. Anaconda): Python3.6, custom Anaconda
- Type of virtual environment used (N/A | venv | virtualenv | conda | …): conda
- Relevant/affected Python packages and their versions: none
- Jedi or Language Server? (i.e. what is
"python.jediEnabled"
set to; more info #3977): jedi
Expected behaviour
Not prompted about Powershell support when we are not using Powershell.
Actual behaviour
We receive this message even when not using powershell:
Activation of the selected Python environment is not supported in PowerShell. Consider changing your shell to Command Prompt.
The notification urges users to Use Command Prompt
. When new developers get set up, they see this message and click Use Command Prompt
, this breaks our documented processes and tools by unconfiguring our shell, bash, within VSCode.
While it has been stated that trying to reconfigure our shell is not the job of the extension, that is exactly what is happening.
I realize that it has also been stated that bash is not supported on windows. We have our part done our part to make sure to configure everything about the shell correctly, with all of our use cases working. The only time it gets broken is when a user accidentally follows the instructions and clicks Use Command Prompt
Everyone but newbies just click always ignore. It kinda ruins the experience for the newbies thought when they get stuck only to realize that their shell is not right.
Issue Analytics
- State:
- Created 4 years ago
- Reactions:3
- Comments:11 (2 by maintainers)
Top GitHub Comments
@DonJayamanne we don’t officially support git bash.
We look for atleast 7 👍 upvotes on the opening comment to gauge general interest in this idea. As there’s unfortunately not enough upvotes then we will close this issue.