Turn off snippets for jedi LSP

Environment data

• VS Code version: 1.55.0
• Extension version (available under the Extensions sidebar): 2021.3.680753044
• OS and version: Ubuntu 20.04 LTS
• Python version: 3.7, deadsnakes
• Type of virtual environment used: virtualenv
• Value of the python.languageServer setting: JediLSP

Expected behaviour

class Thing: pass

Th<tab> # should complete to:
Thing|     # cursor after completed word

Actual behaviour

class Thing: pass

Th<tab> # should complete to:
Thing(|)  # cursor between completed parens

As far as I can tell this is specific to the JediLSP integration – changing my language server to Jedi results in the expected completion.

I can maybe see why this is maybe useful if you’re planning to construct an instance or calling a function, though there are many other places where callable symbols are used in which you don’t want this to happen – passing them as callbacks and type annotations for example.

[bulatb]

It looks like Jedi has this behavior disabled by default, which makes sense: it’s guaranteed to be wrong at least some of the time, in practice pretty often, and it can’t be worked around with muscle memory because its correctness depends on the context. Inconsistent unwanted behavior is the worst UX.

When bracket completion is off, completions are always correct but sometimes less convenient than possible. In all those cases you already know you’re typing a call, so typing ( completes to (|) and gets you most of the convenience back. Never adding brackets never makes you think; always adding brackets always does.

If customizing Jedi settings isn’t on the table, I vote to turn this feature off.

[luabud]

Hey @br3ndonland! Thanks for being up to contributing 😊 I want to talk to the team about this a bit more as we don’t have any jedi specific settings anymore, and the python.analysis.completeFunctionParens one is defined in Pylance’s side, not the Python extension. But a lot of folks are out on vacation until the new year, so this may take some time 😓 as soon as everyone’s back I will talk to them and get back to you, though!