Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Revisit the use of `ITextEditorService` in preferences component

See original GitHub issue

We want to move away from allowing anyone to create heavy typed editor inputs. One clear method we need to deprecate is IEditorService.createEditorInput. The usages we have today need to be changed to untyped inputs.

We seem to be having a few places left:

Preferences @roblourens

Custom Editors

Text Editors

We then have quite a few more usages that imho are less critical because they originate from contexts where we actually do want typed inputs (editor input deserialisation). However, we should probably move those into respective components and out of the editor service itself. I will create a follow up issue on that.