Sign in quick pick dialog: focus movement could be improved
See original GitHub issue- Turn on Settings sync
- Get the following dialog
Press tab
- focus moves to checkbox. Press tab again, focus moves to the other checkbox.
Ideally the first tab would move focus to the “Sign in and Turn on” button. And not to the checkbox
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (4 by maintainers)
Top Results From Across the Web
Setting sync: Sign in dialogs not accessibility friendly #120176
This dialog is very unnacessible. Problems: Once the dialog is created the "Please sign in to synchronize" part is not being read out...
Read more >Building a dialog component - web.dev
A foundational overview of how to build color-adaptive, responsive, and accessible mini and mega modals with the element.
Read more >Windows 7 Dialog Boxes (Design basics) - Win32 apps
A dialog box is a secondary window that allows users to perform a command, asks users a question, or provides users with information...
Read more >Mac accessibility shortcuts
Move the focus to the previous grouping of controls, Control-Shift-Tab ; Move to the adjacent item in a list, tab group, or menu....
Read more >Focus management and inert
Interactive elements can be tabbed to just by virtue of being used. You don't need to set a series of tabindex attributes with...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Yes I can reproduce. Well if VoiceOver was not reading the description before the change for #122054 then there is no point in reverting. Or I misunderstood something?
The issue here is that we are using
aria-activedescendent
to tell the screen reader what is the active element, and based on that the screen reader will read. It would be cool if there is a way to append a label to be read by a screen reader apart from the one provided by the activedescendent. @joanmarie might you have a hint on how to do this? SoA
containsB
, browser focus is onA
,A
hasactivedescendent
pointing toB
. Is there a way forA
to append something to what is read by the screen reader?@TylerLeonhardt If there is not nice way then we will have to use an
aria alert
to announce the placeholder@joanmarie
Sorry about that. I think @isidorn got those mixed up. Let me provide more context.
Based on your text “Select an account to sign in” I think we are talking about two different quick picks. We are talking about the one that says “Please sign in to synchronize your data across devices” that has a “Sign in & turn on” button next to it.
@isidorn said
placeholder
before because thedescription
andplaceholder
visually appear to be in the same place… but theplaceholder
is shown when theinput box
isenabled
, and thedescription
is shown instead when theinput box
isdisabled
.Settings Sync disables the input for this quick pick so we are purely talking about the description here. Sorry for the confusion.
I… am just getting ramped up on A11y-related changes and am quite the noob, sorry… so I’ll let @isidorn answer it correctly but ideally, the description should be read out when the quick pick is shown… so it might look like this:
It’s possible that you see a different quick pick before the “Please sign in to synchronize your data across devices” quick pick… if so, let me know what that one is and we can talk about that one too. I want to fix all the screen reader issues for quick pick 😃