Sometimes problem matchers don't find the end pattern on Windows

I have the following task.json:

{
  "type": "npm",
  "script": "watch-esbuild",
  "group": "build",
  "isBackground": true,
  "problemMatcher": {
    "fileLocation": "relative",
    "pattern": [
      // Doesn't match esbuild errors, just here to get background to work
      {
        "regexp": "^([^\\\\s].*)\\\\((\\\\d+,\\\\d+)\\\\):\\\\s*(.*)$",
        "file": 1,
        "location": 2,
        "message": 3
      }
    ],
    "background": {
      "activeOnStart": true,
      "beginsPattern": "build started",
      "endsPattern": "build finished"
    }
  },
  "presentation": {
    "group": "vscode"
  }
},

Sometimes this happens where the problem matcher never stops it’s progress indicator:

This is because of conpty causing onLineData to fire something unexpected. Given that this problem isn’t likely to go away from conpty, what if on Windows we verified the last line was actually checked after the terminal has been idle for a little bit, that way the problem would be self correcting for a lot of cases shortly after builds finish (provided the end pattern was the last line).

Version: 1.69.0-insider (user setup) Commit: fbf1cf3832d43088e27837dbb68d24ab65a098c1 Date: 2022-06-17T05:16:33.731Z Electron: 18.3.3 Chromium: 100.0.4896.160 Node.js: 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.22000

[r3m0t]

Looks like my issue is a separate one, webpack isn’t emitting newlines so onLineData isn’t fired- (I have process.env.WEBPACK_CLI_START_FINISH_FORCE_LOG set to “1” )

https://github.com/webpack/webpack-cli/blob/d390d32fe0f2491c5cc3a8dfae3ccc3962a5911b/packages/webpack-cli/src/plugins/CLIPlugin.ts#L58-L61

esbuild does emit newlines as shown in @Tyriar 's screenshot and here:

https://github.com/evanw/esbuild/blob/698898f86615a69f52d2e00681a13fe2b8635e88/pkg/api/api_impl.go#L1269

I didn’t repro @Tyriar 's issue. I think I’ll just submit a PR to webpack to solve my issue.

[meganrogge]

https://github.com/microsoft/vscode/blob/3bed084d432840a7bc40d378e5b354e60ccc0067/src/vs/workbench/contrib/tasks/common/problemCollectors.ts#L142-L168