Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Source control svg icons stay dark when the repository row is selected.

See original GitHub issue

Does this issue occur when all extensions are disabled?: N/A

Version: 1.72.0 (Universal) Commit: 64bbfbf67ada9953918d72e1df2f4d8e537d340e Date: 2022-10-04T23:21:58.256Z Electron: 19.0.17 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin x64 21.6.0 Sandboxed: No

Steps to Reproduce:

Install the git-graph extension
Open a repository
Open the source control view
Make sure you currently have a light theme
Click the repository row so it becomes blue

Expected result: The git graph icon changes along with the other icons.

Actual result: The git graph icon stays black

more info here: https://github.com/mhutchie/vscode-git-graph/issues/690

https://user-images.githubusercontent.com/2737650/196002067-29002c28-c71b-42a3-8806-85e5e143fe2f.mp4

Issue Analytics

State:
Created a year ago
Comments:9 (5 by maintainers)

Top GitHub Comments

2reactions

joaomorenocommented, Oct 20, 2022

This is more SCM specific than anything else, @lszomoru can you take a peek?

0reactions

daviddossettcommented, Oct 19, 2022

Ok, it looks like they did supply the correct icons—the issue is then specifically just about static SVGs reacting to a selected state of the list item. I don’t know what the best solution would be since simply switching to the “light” icon wouldn’t really work either. We would instead need to dynamically update the fill of the svg. Or something similar.

cc @joaomoreno for general list widget knowledge: who would be the best person to assign here?

Top Results From Across the Web

Git graph icon is barely visible with the Light+ theme #690

Steps to reproduce the behaviour: Click the source control button in the activity bar. Of the repository is not selected (not blue), click...

Material Symbols and Icons - Google Fonts

Introducing Material Symbols. Material Symbols are our newest icons consolidating over 2,500 glyphs in a single font file with a wide range of...

Dark-GitLab by vednoc - UserStyles.world

A new free and open-source, community-driven, modern alternative to userstyles.org.

How to add images in select list? - Stack Overflow

You can use iconselect.js; Icon/image select (combobox, dropdown) ... Expansions) { <div class="form-row"> <div class="custom-control custom-checkbox ...

User and Workspace Settings - Visual Studio Code

In the example below, the Side Bar location and file icon theme have been changed. ... Below, the Source Control settings are focused...