Status bar can dispose commands that are still in use

Type: Bug

The users of our extension do see this error pop-up

It’s also present in the console

It happens at random, but can 100% be reproduced by spamming a status bar button that runs a command.

It seems like there is a sleeping bug in the vscode codebase, and our extension is triggering it for some reason. Note that there isn’t an expansion triangle on the pop-up, and that the pop-up does not come from the extension.

The status bar button runs a command that focuses an item in a TreeView. The bug seems to happen only when the tree view is being updated: to reproduce you need to spam the button while the treeview is being refreshed. I’m unsure of the correlation but it’s a reliable way to reproduce.

Steps to reproduce

Here are some steps to reproduce, for what it’s worth. They’re a bit annoying since it requires an account with CircleCI, but all it does is provide a status bar button that we can click.

1. Install https://marketplace.visualstudio.com/items?itemName=circleci.circleci
2. Log in and select a project
3. Re-run a workflow
4. Spam the status bar button (“CircleCI: Running”) while the tree view is being updated with the workflow you just re-run
5. Hopefully observe the error pop-up. Otherwise, try again from step 3

If the root cause cannot be identified, could you please provide us with a way for users to not have this error pop-up? Just a console log would be enough.

Relates to #84153

The error comes from here in the vscode codebase: https://github.com/microsoft/vscode/blob/a8c16a0d82bc5fd110ad2a697e0345e94ccebec2/src/vs/workbench/api/common/extHostCommands.ts#L411

I cannot attempt to reproduce on insiders because of another pending issue.

VS Code version: Code 1.72.2 (Universal) (d045a5eda657f4d7b676dedbfa7aab8207f8a075, 2022-10-12T22:16:30.254Z) OS version: Darwin arm64 21.4.0 Modes: Sandboxed: No

System Info

Item	Value
CPUs	Apple M1 Max (10 x 24)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	5, 4, 3
Memory (System)	32.00GB (2.59GB free)
Process Argv	–crash-reporter-id fb2dea6a-4e3a-4679-b6a6-55aae7e25be9
Screen Reader	no
VM	0%

Extensions (8)

Extension	Author (truncated)	Version
Bookmarks	ale	13.3.1
circleci	Cir	1.0.1
vscode-eslint	dba	2.2.6
gitlens	eam	12.2.2
go	gol	0.35.2
remote-ssh	ms-	0.90.1
remote-ssh-edit	ms-	0.84.0
vim	vsc	1.24.2

(1 theme extensions excluded)

A/B Experiments

vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
pyindex848cf:30577861
nodejswelcome1:30587005
fc301958:30595537
2e4cg342:30596373

[sguilliaci]

Creating a standalone snippet will take some time. My colleagues or I will do it at some point. You can park this ticket for now. Thanks for investigating

[VSCodeTriageBot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!