Updates still applied despite policy setting

Type: Bug

1. Set update.mode = none (e.g. via group policy)
2. Still get the “1” badge on the settings icon in the lower left corner telling you about an update

The “Main” log after startup shows:

[2022-10-12 10:54:29.870] [main] [info] update#setState idle
[2022-10-12 10:54:30.677] [main] [info] Starting extension host with pid 17568 (fork() took 15 ms).
[2022-10-12 10:54:59.877] [main] [info] update#setState checking for updates
[2022-10-12 10:54:59.881] [main] [info] update#setState downloading
[2022-10-12 10:54:59.883] [main] [info] update#setState downloaded

Additionally disabling update.enableWindowsBackgroundUpdates instead makes an obnoxious notifcation pop up on every start/window reload.

VS Code version: Code 1.72.0 (64bbfbf67ada9953918d72e1df2f4d8e537d340e, 2022-10-04T23:20:39.912Z) OS version: Windows_NT x64 10.0.19044 Modes: Sandboxed: No

System Info

Item	Value
CPUs	AMD Ryzen 7 5700G with Radeon Graphics (16 x 3793)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	undefined
Memory (System)	27.88GB (15.65GB free)
Process Argv	–crash-reporter-id bf85a791-c1e6-499d-9010-2c54f6076653
Screen Reader	no
VM	0%

Extensions (18)

Extension	Author (truncated)	Version
EditorConfig	Edi	0.16.4
gitlab-workflow	Git	3.53.0
python	ms-	2022.16.0
vscode-pylance	ms-	2022.10.10
jupyter	ms-	2022.9.1202862440
jupyter-keymap	ms-	1.0.0
jupyter-renderers	ms-	1.0.10
vscode-jupyter-cell-tags	ms-	0.1.6
vscode-jupyter-slideshow	ms-	0.1.5
remote-ssh	ms-	0.90.1
remote-ssh-edit	ms-	0.84.0
remote-wsl	ms-	0.72.0
cpptools	ms-	1.12.4
hexeditor	ms-	1.9.9
remote-repositories	ms-	0.22.0
rust-analyzer	rus	0.3.1238
rewrap	stk	1.16.3
vscode-lldb	vad	1.8.1

(1 theme extensions excluded)

A/B Experiments

vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
2144e591:30553903
pyindex848:30577860
fc301958:30573243

[joaomoreno]

I’ve added trace logging to the NativePolicyService which should help us get more visibility on this.

@TreeBranches, @ptdalen, @madig Could you install VS Code Insiders tomorrow, then run Developer: Set Log Level..., set the logging level to Trace and open the Main log in the Output pane and show me whatever logs you might have related to NativePolicyService?

[joaomoreno]

@madig, @sandy081 has pushed a few more log statements here. Can you give this a try again on the latest insiders and send us the full logs? Thank you!