User-defined shell keybindings are triggered by VS Code input

Several shells (fish, bash, zsh) include vi mode keybindings. It’s common for users to rebind vi escape to something like df, jj, or jk.

When interfacing with the shell, VS Code behaves as if it were a user typing keys, which may trigger vi escape if file names or other text input to the shell contains the escape sequence.

To show the problematic behavior (assuming the shell is zsh): Include these lines in your .zshrc

bindkey -v
bindkey -M viins 'jj' vi-cmd-mode

In VS Code, try to run a Python file named jj.py. VS Code enters this file name into the shell, which triggers the escape sequence and causes the shell to interpret .py following the jj as vi normal mode commands.

If VS Code input text to the shell with bracketed paste, this would not happen.

[CharlonTank]

Not sure if this is related, but I use Spectacle to move and resize my windows. It used to work perfectly, but now, since today’s update, I cannot use my shortcut to resize my VSCode instance. The shortcuts I used were control+option+command+(left/right/down/up) to move and resize, and option+command+f to toggle fullscreen(not fullscreen but resized as fullscreen). These shortcuts do nothing in VSCode and are not triggered anymore through Spectacle

Thank you, I’m gonna post this as a new issue. ❤️

[Tyriar]

This caused a regression unfortunately so reopening https://github.com/microsoft/vscode/issues/154863

The actual fix is more involved than I thought, we will need to be able to pass in a flag for whether to wrap in bracketed paste mode into the sendSequence command, internal API, extension API. An extension could wrap what it’s sending in bracketed paste mode now but that won’t work when the shell isn’t in bracketed paste mode and the extension is not able to determine that.