VS Code has Wayland logo on Overview instead of its own logo

Issue Type: Bug

Please see the bug description here: https://bugs.kde.org/show_bug.cgi?id=438951

VS Code version: Code 1.58.2 (c3f126316369cd610563c75b1b1725e0679adfb3, 2021-07-14T22:30:16.440Z) OS version: Linux x64 5.11.0-25-lowlatency Restricted Mode: No

System Info

Item	Value
CPUs	Intel® Core™ i5-8250U CPU @ 1.60GHz (8 x 1800)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off opengl: enabled_on rasterization: disabled_software skia_renderer: enabled_on video_decode: disabled_software vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	6, 4, 3
Memory (System)	7.64GB (0.12GB free)
Process Argv	–no-sandbox --unity-launch --crash-reporter-id 9cc3662d-ccfb-4569-83fb-26560f111f8b
Screen Reader	no
VM	0%
DESKTOP_SESSION	plasma
XDG_CURRENT_DESKTOP	KDE
XDG_SESSION_DESKTOP	KDE
XDG_SESSION_TYPE	x11

Extensions (52)

Extension	Author (truncated)	Version
better-comments	aar	2.1.0
Bookmarks	ale	13.1.0
laravel-extra-intellisense	ami	0.6.1
html-class-suggestions	And	1.1.1
vscode-intelephense-client	bme	1.7.1
path-intellisense	chr	2.4.0
vs-code-semicolon-insertion	chr	0.0.6
gitignore	cod	0.7.0
laravel-goto-view	cod	1.3.4
bracket-pair-colorizer-2	Coe	0.2.1
githistory	don	0.6.18
gitlens	eam	11.6.0
vscode-html-css	ecm	1.10.2
EditorConfig	Edi	0.16.4
prettier-vscode	esb	8.1.0
php-debug	fel	1.17.0
php-intellisense	fel	2.3.14
php-pack	fel	1.0.2
gc-excelviewer	Gra	3.0.42
output-colorizer	IBM	0.1.2
icon-fonts	idl	2.5.2
vscode-colorize	kam	0.11.1
vscode-gutter-preview	kis	0.27.1
vscode-jumpy	krn	1.0.2
dotenv	mik	1.0.1
vscode-docker	ms-	1.15.0
csharp	ms-	1.23.14
python	ms-	2021.7.1060902895
vscode-pylance	ms-	2021.7.7
jupyter	ms-	2021.8.1054968649
remote-containers	ms-	0.187.1
remote-ssh	ms-	0.65.7
remote-ssh-edit	ms-	0.65.7
remote-wsl	ms-	0.58.2
vscode-remote-extensionpack	ms-	0.21.0
es6-css-minify	olb	3.3.2
laravel-blade	one	1.25.0
laravel-extension-pack	one	1.0.0
laravel5-snippets	one	1.13.0
vscode-versionlens	pfl	1.0.9
LiveServer	rit	5.6.1
bash-debug	rog	0.3.9
laravel-artisan	rya	0.0.28
partial-diff	ryu	1.4.3
vscode-javascript-booster	sbu	14.0.1
indenticator	Sir	0.7.0
laravel-goto-controller	ste	0.0.12
code-spell-checker	str	1.10.2
sort-lines	Tyr	1.9.0
vscode-icons	vsc	11.6.0
local-history	xyz	1.8.1
material-theme	zhu	3.11.2

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vstes516:30244333
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
vscextlang:30333561
binariesv615:30325510
vsccppwtct:30329789
pythonvssor306:30344512
bridge0708:30335490

[deepak1556]

Thanks for linking the upstream bug, unlike chrome which used to case the WM_CLASS before https://chromium-review.googlesource.com/c/chromium/src/+/3071380 electron just used the result of the api app.setName from apps https://github.com/electron/electron/blob/6aece4a83d12b6ec610994895e43560ae1aa77dc/shell/browser/native_window_views.cc#L254 and when the api is not called by the apps it will use the value of NAME field from the desktop file https://github.com/electron/electron/blob/6aece4a83d12b6ec610994895e43560ae1aa77dc/shell/common/application_info_linux.cc#L38-L48

Currently VSCode uses capitalised value for the field, I can fix this on our end but would rather implement the fix in electron so that each app need not cover this case for wayland.

[Desmond121]

Workaround

In 1.70.x, the wm_class value for vscode is empty under wayland. After updating to 1.71.x , the wm_class value is fixed

Then based on @rstrube 's workaround, change the StartupWMClass to code-url-handler and it works. This is how it looks like before changing, the icon is missing the app cannot be identified as the one I’v pinned in dock: This is how it looks after fixing:

I’m not sure who should take care of the .desktop file, The vscode developer or the AUR package maintainer?