Warning in package.json when specifying icon without https repository

• VSCode Version: 1.42.1
• OS Version: Windows 10 (Windows_NT x64 10.0.16299)
• vsce version: 1.73.0

This is basically the issue described in #30434, but the warning message does not seem to be “true” in my case. I am opening this issue because that one is closed.

I am building an extension for company internal use only. My source code repository is not available over https, but the icon works fine when I’ve package the extension as a VSIX.

Here’s a screenshot of the warning:

I’ll admit it disappointed me when I thought I could not have an icon in my extension. My 1.0.0 version did not have an icon because of the warning message. For 1.0.1, I decided to try it anyway, and it worked.

Maybe, it’s true for extensions published on the marketplace? If so, it may be better to indicate such in the message. Maybe change the text to something like this: “An icon requires a repository with HTTPS protocol to be specified in this package.json, when publishing to the marketplace”?

Steps to Reproduce:

1. Add a relative icon reference to an extension package.json
2. Do not have a repository that is available over https. (Mine is a directory on a shared drive.)
3. See the path to the icon get orange squiggles under it with the hover text “An icon requires a repository with HTTPS protocol to be specified in this package.json.”

Does this issue occur when all extensions are disabled?: Yes

[zimmski]

@chrmarti can this issue please be reopend. The warning seems to be invalid, e.g. https://github.com/marp-team/marp-vscode/blob/main/package.json#L37 is doing a relative path and including their icons into the extension. The marketplace shows the icon https://marketplace.visualstudio.com/items?itemName=marp-team.marp-vscode

I looked at other open source extensions too that are on the current top list.

[saqibRafique]

I’ve added webpack process image rule but no luck 😦