Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Test Console fails if path contains forward slash

See original GitHub issue

Description

When using the latest SDK, you get an error if your VSTestResultsDirectory contains a forward slash (on Windows).

Microsoft (R) Test Execution Command Line Tool Version 16.3.0-preview-20190808-04
Copyright (c) Microsoft Corporation.  All rights reserved.

The path 'C:\Users\tagoo\repos\clangsharp\artifacts/tst/Debug/' specified in the 'ResultsDirectory' is invalid. Error: Illegal characters in path.

Steps to reproduce

Clone https://github.com/microsoft/clangsharp
Run .\scripts\cibuild.cmd

Expected behavior

Everything succeeds (as with previous versions)

Actual behavior

The Test Execution Command Line Tool fails with the above diagnostics.

Issue Analytics

State:
Created 4 years ago
Reactions:1
Comments:11 (11 by maintainers)

Top GitHub Comments

2reactions

JeremyKuhnecommented, Aug 12, 2019

As a fundamental design principle, don’t try and validate paths. You’ll inevitably get it wrong. Let Path.GetFullPath() normalize it for you (which it does through the OS) and let the OS tell you if the path isn’t usable when you try to use it.

Note that even if you do validate a path, there is no way to ensure that the path will be the same next time you access it. Files turn into directories and vice versa, paths get deleted, etc.

1reaction

vagisha-nidhicommented, Aug 29, 2019

@eerhardt Yes the issue should be closed. We have made a release as well with this fix. The fix will go into dotnet cli 3.0 also.