More granular error codes

Hello. Briefly - how would I detect situation where I cannot get lock because of all Redis instanes gone (eg. db connection error on all instances).

More details:

try {
    lock = await redlock.lock("x", 1000);
} catch (err) {
    // Db connection problem (what I want to log and response with appropriate error code/message)
    //   OR
    // Alredy locked by other instance of my app and I want to ignore it (eg. I will respond with 202 code to signal that task already in progress)
}

Is there a way I can distinguish between type of errors, eg:

1. Unable to acquire/extend lock because of db connection error.
2. Unable to acquire lock because resource already locked.
3. Unable to extend lock because it already expired.

Is it possible that you will introduce LockError.code property and expose (export) some LOCK_ERROR_CODE_… consts?

Regards, Wojtek

[fider]

Hi Mike, I got your point - await lock() request (promise) should not be rejected in each case because it will destory flow. Emitting event also have no sense in “classic” application that use step-by-step (non event) flow.

IMO. it makes sense to reject it in case if connection to each db will fail, are you ok with this (or this is already implemented behavior)?

pon., 1 paź 2018 o 07:38 Mike Marcacci [e-mail] napisał(a):

Another complication is that of retries…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mike-marcacci/node-redlock/issues/43#issuecomment-425794712, or mute the thread https://github.com/notifications/unsubscribe-auth/ABY-TmNnFYUh-EpKzeei_IxONkBL1ej6ks5ugapugaJpZM4W2YmU .

– Wojciech Fiderek

Mobile: [phone]

[mike-marcacci]

The newest version has all the relevant information attached to an error. Accessing all of this information is still a bit complex, because we can sometime know that something has errored before all parallel requests have completed. See the tests for an example of how to inspect these:

https://github.com/mike-marcacci/node-redlock/blob/078c7270a48596db8a23b4884f88db1f1eb3c18b/src/single.test.ts#L14-L31