question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

All the contributors

See original GitHub issue

I just noticed that there are only 30 contributors listed on https://turnipprophet.io/ while the GitHub repository lists 53 contributors now. The is because the API call currently used only returns page 1 of the contributors, and you get 30 contributors per page.

https://github.com/mikebryant/ac-nh-turnip-prices/blob/a400ee92180459f07052022133c4d0fcfd3209d7/js/contributors.js#L4

To get the rest of the contributors, you would need https://api.github.com/repos/mikebryant/ac-nh-turnip-prices/contributors?page=2, and once there are over 60 contributors, page 3 and so on.

It seems that v3 of GitHub’s API can respond with URLs for the next page and the last page, so it would be possible to build logic to loop through all available pages and display the entire list of contributors.

Is this something we want to do? Or is it preferable to only list the first 30 contributors?

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
theRTC204commented, May 11, 2020

I appologize, I didn’t mean to suggest raising the issue was a bad idea. It’s good to have the issue open for tracking until one of the open PRs is accepted!

1reaction
theRTC204commented, May 11, 2020

We now have 3 active PRs to address this concern… #302, #311 and now #358.

Read more comments on GitHub >

github_iconTop Results From Across the Web

All Contributors: Recognize all contributors, not just the ones ...
1. Install the Bot to your project · 2. Start a pull request or comment · 3. Mention the @all-contributors Bot · 4....
Read more >
Recognize all contributors, not just the ones who push code
This is a specification for recognizing contributors to an open-source project in a way that rewards every contribution, not just code. The basic...
Read more >
Acknowledge all Contributors to a Project • allcontributors - Docs
Acknowledge all contributors to a project via a single function call. The function appends to a README or other specified file(s) a table...
Read more >
all-contributors - npm
Recognize all contributors, not just the ones who push code ✨. Latest version: 2.17.0, last published: 3 months ago.
Read more >
All Contributors Plugin - Intuit
All Contributors Plugin. Automatically add contributors as changelogs are produced. This plugin maps one of the contribution types to a glob or array...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found