All the contributors
See original GitHub issueI just noticed that there are only 30 contributors listed on https://turnipprophet.io/ while the GitHub repository lists 53 contributors now. The is because the API call currently used only returns page 1 of the contributors, and you get 30 contributors per page.
To get the rest of the contributors, you would need https://api.github.com/repos/mikebryant/ac-nh-turnip-prices/contributors?page=2
, and once there are over 60 contributors, page 3 and so on.
It seems that v3 of GitHub’s API can respond with URLs for the next page and the last page, so it would be possible to build logic to loop through all available pages and display the entire list of contributors.
Is this something we want to do? Or is it preferable to only list the first 30 contributors?
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (3 by maintainers)
Top GitHub Comments
I appologize, I didn’t mean to suggest raising the issue was a bad idea. It’s good to have the issue open for tracking until one of the open PRs is accepted!
We now have 3 active PRs to address this concern… #302, #311 and now #358.