required_with and required_if rules cannot handle 0 value

Sample code : method: 'numeric', description: 'required_with:method|required_if:method,0'

Validations are not triggered when method value is 0.

[mikeerickson]

I can see the point here. Let me stew on this for a bit. My initial thinking is, if the value is required, but an empty string is supplied, theoretically that should fail validation.

Now, on the bad side, if I make this change, then I risk breaking other applications which don’t adopt this strictness

[codebury]

Hi.

The issue comes from the fact that required_if rule takes it’s parameter as string, so what it’s doing is: 0 === '0'.

As a workaround, I used the registerImplicit method provided by Validator class:

const required_if_rule = function (val, req, attribute) {
        req = this.getParameters();
        let op = this.validator._objectPath(this.validator.input, req[0]);        
        if ((op != undefined && op != null ? op.toString() : null) === req[1]) {
            return this.validator.getRule('required').validate(val);
        }
        return true;
    }

Validator.registerImplicit('required_if', required_if_rule, 'The :attribute field is required when :other is :value');