question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bad rendering of the data-position attribute on script tag

See original GitHub issue

Hello,

With Mini Profiler 4.2.1 the attribute data-position on script tag has 2 double quote ending: data-position=“Left”"

On EDGE : HTML1423 warning on console.

The script tag render :

<script async id="mini-profiler" src="/mini-profiler-resources/includes.min.js?v=4.2.1+b27bea37e9" data-version="4.2.1+b27bea37e9" data-path="/mini-profiler-resources/" data-current-id="03f0b54a-0032-4e3b-9a44-24c25344505c" data-ids="03f0b54a-0032-4e3b-9a44-24c25344505c" data-position="Left"" data-scheme="Light" data-authorized="true" data-max-traces="15" data-toggle-shortcut="Alt+P" data-trivial-milliseconds="2.0" data-ignored-duplicate-execute-types="Open,OpenAsync,Close,CloseAsync"></script>

My config:

<PackageReference Include="MiniProfiler.AspNetCore.Mvc" Version="4.2.1" />
<PackageReference Include="MiniProfiler.EntityFrameworkCore" Version="4.2.1" />

services.AddMiniProfiler().AddEntityFramework();

and

<mini-profiler />

Best Regards

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:2
  • Comments:10 (4 by maintainers)

github_iconTop GitHub Comments

3reactions
NickCravercommented, Dec 11, 2020

This was fixed already, but was not promoted to the NuGet feed yet. Look for 4.2.22 landing on NuGet in just a bit, or available on MyGet already!

1reaction
dotnetshadowcommented, Dec 9, 2020

I’m seeing the same issue.

This has the unintended issue causing other problems with packages such as WebMarkupMin https://github.com/Taritsyn/WebMarkupMin/issues/112

Read more comments on GitHub >

github_iconTop Results From Across the Web

Does the <script> tag position in HTML affects performance ...
Script tags inside the head element will be loaded and interpreted before any HTML is rendered, this blocks HTML/CSS rendering.
Read more >
The Script element - HTML: HyperText Markup Language
You can include render token inside a blocking attribute; the rendering of the page will be blocked till the script is fetched and...
Read more >
Boolean attributes in script tag not rendered correctly #197
In #188, we added the ability to specify <script> attributes with a list of values. However, it doesn't seem to support boolean attribites ......
Read more >
When should you add the defer attribute to the script ...
In short: with defer on a script in the head , the JavaScript file will download in the background while the rest of...
Read more >
Where to put a script tag — into head or body end?
So it seems that, regardless of the script type, rendering of the HTML is reproducibly blocked when the script is loaded from the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found