Passthrough not working for cross-origin requests

Hi,

I am setting up my routes like so:

new Server({
	routes() {
		this.post(<some-fully-qualified-route>, {...});

		this.post(<another-fully-qualified-route>, {...});

		this.passthrough();
	}
});

This only passes through requests made on same origin but does nothing for the other cross-origin requests. Is this an expected behaviour? If yes, how can we achieve pass-through behaviour for all remaining request except for the one mentioned explicitly in the routes?

[samselikoff]

You can pass through all requests for a single domain like this

this.passthrough('http://api.amazon.com/**')

but unfortunately you can’t wildcard all domains. But, passthrough has a function version that you can use to perform whatever check you want:

this.passthrough(request => {
  return request.url.match(/regex/)
})

Let me know if that helps! Here are the full passthrough guides. I know this is a confusing API today, we have plans to improve it so you can passthrough anything that is not defined, and that’s very high priority behind some other stuff we’re working on now.

[ryanto]

Hi @rassie

Maybe only evaluate and apply this.passthroughChecks if originalCheckPassthrough is false?

I think this seems reasonable, but I’m having a hard time visualizing a config that highlights this change. Could you share your server’s routes and examples of requests you’d like mirage to handle vs passthrough. That’ll help!

I think getting a test case of sorts in place is the best way to see what’s going on.