If a frequently used custom emoji is removed, it will remain in the frequently used
See original GitHub issueI’m loading custom emoji into the picker, and having done some tests, I’ve removed a few. From this point you get a bunch of emoji is undefined
errors because the removed emoji is still present in the emoji list for the frequent category.
Unsure at the moment as to a work around for this, other than if the emoji isn’t currently present in the emoji list or is undefined, ignore it in the frequent list.
Did some more research into this, it does look like at one point this was a feature in a previous version with this pull request: #133.
A quick glance at the code makes me think this might fix it:
Picker.js
renderEmojiButton() {
if (emoji === undefined) {
return null
}
....
}
And
config.js after while loop starts
while (i--) {
...
if (emoji === undefined) {
continue
}
...
}
But, at first glance it might not fix the ordering of the frequently used list, and merely omit emojis that cannot be found, leaving you with uneven groupings in the middle.
Issue Analytics
- State:
- Created a year ago
- Comments:5 (2 by maintainers)
@alixcui-glean Of course. The prompt to add custom emojis is actually not part of the library, it’s just for the example website. Here’s an example: https://github.com/missive/emoji-mart/blob/2b1b67a4d81781aaee7700ce1bc0c05aa104dd2d/packages/emoji-mart-website/index.html#L271-L294
Cheers! Extremely small ping to remind you to update https://missiveapp.com/open/emoji-mart/ but otherwise nothing to say except one big thanks! 😃