Setting View Filter shows Addon Error in Eventlog

error: Addon error: Traceback (most recent call last):
    File "/home/coldfire/Projects/mitmproxy/mitmproxy/addons/view.py", line 521, in update
        idx = self._view.index(f)
    File "/home/coldfire/Projects/mitmproxy/venv/lib/python3.6/site-packages/sortedcontainers/sortedlist.py", line 2343, in index
        raise ValueError('{0!r} is not in list'.format(val))
    File "/home/coldfire/Projects/mitmproxy/mitmproxy/http.py", line 182, in __repr__
        return s.format(flow=self)
    File "/home/coldfire/Projects/mitmproxy/mitmproxy/connections.py", line 215, in __repr__
        host=self.address[0],
TypeError: 'NoneType' object is not subscriptable

Steps to reproduce the problem:

1. Open mitmproxy
2. set a value for view_filter in Options or using the : set view_filter={str}
3. Open a attached browser and open any url
4. Quit the browser and Open the Eventlog in mitmproxy.

Any other comments? What have you tried so far?

Another error occuring for the view_filter option. I was working on a fix for #2801 #2951 when i noticed this other error occurs if any value is setup in view_filter. I think it requires a complete patch once and for all.

System information

Mitmproxy: 4.0.0.dev103 (commit 77ed33b) Python: 3.6.4 OpenSSL: OpenSSL 1.1.0g 2 Nov 2017 Platform: Linux-4.14.21-1-MANJARO-x86_64-with-arch-Manjaro-Linux

[mhils]

I don’t think there’s another issue here. From the original traceback, it looks like we are checking if a flow is in the view, which isn’t the case. This is totally expected, the problem here was that sortedcontainers used {0!r}, which triggers the flows __repr__, which then failed. It’s okay for flows to have a server_conn.address of None, see e.g. the http_connect example.

[fenilgandhi]

@mhils, The pull-request #3008 only handles the scenario where the address is None and gracefully handles it but the bug which actually causes the value of an address to be None yet exists somewhere.

So maybe until a fix can found for it, shall i keep this issue open or only handling the None value completely fixes the bug somehow ?