MultipleModelField should accept other types as iterable not just list

It seems to me that MultipleModelField should accept any iterable such as a Django queryset, tuple, and set – not just a list.

I commonly have forms using forms.ModelMultipleChoiceField which in the cleaned_data returns a queryset. I am having to wrap list around the data from a forms.ModelMultipleChoiceField to coerce it into a list for the library.

Views.py:

DuplicateMergeService.execute({
    'duplicates':list(form.cleaned_data['duplicates']),
    'by': request.user
})

Seems like MultipleModelField should accept any iterable and not be restricted to list

[jackton1]

Personally switching from using the MultipleModelField -> forms.ModelMultipleChoiceField for queryset.

my_models = forms.ModelMultipleChoiceField(queryset=MyModel.objects.all())

OR

recipients = forms.MultipleChoiceField(choices=[...])

[peterfarrell]

@jackton1 Thanks for the feedback and mentioning the allow_unsaved. I guess @c17r already committed a change so I won’t submit the PR I started last night. Glad to see this improvement.