question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

BUG: 3D functions return non-public members

See original GitHub issue

@GuillaumeFavelier we need a public equivalent to mayavi.core.api.Scene for whatever we currently return for create_3d_figure that users can pass around to 3D functions as fig=fig etc. Can you work on this separately? Then we can git grep "PyVista renderer" and know all the places we need to put in a reference that links properly.

adapted from https://github.com/mne-tools/mne-python/pull/9945#issue-772527626

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
larsonercommented, Feb 14, 2022

Then we can think about the contract that this fig should fulfill.

I think the smallest API as possible is best. So maybe just that:

  1. It can be passed as a fig to MNE-Python functions, and probably also that
  2. The .plotter attribute is accessible, and is a PyVista plotter instance

WDYT?

0reactions
GuillaumeFaveliercommented, Feb 15, 2022

You can go for it @larsoner, it’s always possible to refactor things around later on

Read more comments on GitHub >

github_iconTop Results From Across the Web

C# 8.0 "using" bug? - Microsoft Q&A
Hello,. When declaring: using anObj = new MyObj();. it is normal and correct to indicate an error, if anObj, is to be overwritten:....
Read more >
Bug on a custom C++ class - compiler construction
Regarding how to make it prettier: I would create an accessor function that returns a const reference to a Punto. Let me update...
Read more >
Advanced search reference - JQL functions | Jira Software Cloud
Returns requests that the members have shared with or kept private from that organization, and with any other organizations they're a member of....
Read more >
Troubleshooting Cloud Functions - Google Cloud
'gcloud projects add-iam-policy-binding <PROJECT_ID> --member=serviceAccount: ... You can always check using gcloud functions call which returns the correct ...
Read more >
Input System bugs - Unity Forum
Hi, I've been trying the new input system and so far I really like it! It's hard to pick something specific, as I...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found