eeglab events backward compatibility

Currently when reading eeglab files I get deprecation warnings because the mne function internally uses read_events_eeglab and not the function to read events as annotations and then back as events. I am sure this is temporary, but it is annoying enough that I can volunteer to fix it. 😃

And since I am volunteering - some other things regarding backwards compatibility of the new system with the new one:

• I was reading a file today that gave no events when read the old way (read then mne.find_events) but when read with the new way egglab events -> annotations -> events array gave one event (which is correct). It was not on my computer so I cannot check or share the file at the moment but I should be able in a day or so.
• I think the eeglab reader originally converted integer event types (EEG.events.type) to the same integer values in events array. Now, when turning annotations to events the events are numbered according to their presentation order and the correct values are given in a separate dict. That means that I have to correct the values myself (because otherwise every subject could have different event values) or pass event_id={str(x): x for x in range(255)} when constructing events from annotations.

[mmagnuski]

@massich - this was done, right, the issue can be closed?

[mmagnuski]

And even if event_id does not do much when sim_channel is False it is more important to inform the user that event_id is going to be removed and events should read in a different way.