Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ENH: add `auto` param in filter functions

See original GitHub issue

Currently, classic high pass filtering (i.e. < 0.2 Hz) crashes when uses default, because the transition bandwidth are too large.

As changing the default would create backward incompatibility and differences with MNE-C .

We suggest to add an auto param to adapt the transition bandwidth according to the frequency.

cc @choldgraf @Eric89GXL @jona-sassenhagen

Issue Analytics

State:
Created 7 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

larsonercommented, May 19, 2016

I’ll probably dig into this issue at the same time as #3227 (filtering FAQ), hopefully this summer sometime.

I should also look and see what MNE-C does for filtering, since I don’t think it’s identical to what we do (IIRC our filters are at least longer).

0reactions

choldgrafcommented, May 23, 2016

I’d be +1 for that if it doesn’t take too much time, though I bet using an ‘auto’ option as well as including some good documentation on this would be sufficient.

On Mon, May 23, 2016 at 10:28 AM, Eric Larson notifications@github.com wrote:

It just occurred to me that we could also give some warnings when people use filters that are too long for the given data, e.g. a FIR filter with too many coefficients or an IIR filter that rings too long (although this might be too expensive to estimate, I’d have to see).

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/mne-tools/mne-python/issues/3239#issuecomment-221038322