ENH: plot_topomap, plot_joint & plot: API homogeneity for scalings/scale parameters
See original GitHub issueSmall API heterogenity: different plotting functions use similar parameters slightly differently (and named slightly differently)
- scaling:
evoked.plot(scalings=dict())
butevoked.plot_topomap(scale=dict() | float)
- units:
evoked.plot(units=dict())
butevoked.plot_topomap(unit=dict() | str)
- max amplitude:
evoked.plot(ylim=dict())
butevoked.plot_topomap(vmin=dict() | float, vmax=dict() | float())
Changing parameter names can be annoying for deprecation, but I suggest we at least make their input similar (e.g. always accepts both dict
and float
).
Additionally, evoked.plot_joint()
could gather the parameters common to plot()
and plot_topomap()
to simplify it. WDTY @jona-sassenhagen ?
Issue Analytics
- State:
- Created 7 years ago
- Comments:12 (12 by maintainers)
Top Results From Across the Web
mne.viz.plot_topomap — MNE 1.2.2 documentation
Plot a topographic map as image. Parameters: data array , shape (n_chan,). The data values to plot ...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Can we split this into multiple smaller PRs?
Oh it is in the top post.
I think the only clean way to fix it is to deprecate.