question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Expected values from find_edf_events: missing annotations for EDF+D, but not EDF+C in 0.18

See original GitHub issue

Using MacOSX and conda environment, I downloaded two versions of MNE. Using mne==0.17.2 and 0.18 current version, you take two sets of EDF files (EDF+D and EDF+C). They can be manually converted using edfbrowser.

For the EDF+D file it works for 0.17.2, but not 0.18.

Both versions work when the file is in EDF+C format though. Sample code is below. Test data is available upon request (@larsoner has seen the data though)

import mne

# in these two runs, only 0.17.2 matches for both files
# in 0.18, only the first annotations gets the full annotation list

if __name__ == '__main__':
    fpath = "./test_edfc.edf"
    raw = mne.io.read_raw_edf(fpath, preload=True)
    annotations = mne.events_from_annotations(raw)
    print(annotations)

    fpath = "./test_edfd.edf"
    raw = mne.io.read_raw_edf(fpath, preload=True)
    annotations = mne.events_from_annotations(raw)
    print(annotations)

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:24 (24 by maintainers)

github_iconTop GitHub Comments

1reaction
adam2392commented, Oct 1, 2019

@larsoner trying to see how I can possibly trim them. Will add them if possible.

1reaction
larsonercommented, Oct 1, 2019

@adam2392 is it possible for you to make versions of these files as small as possible (e.g. 1MB) that still show the problem? If so then we can incorporate them into our testing data as a regression test. The current size (100MB+) is too big for us to do this

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found