Some issues with EDF export
See original GitHub issueI found some issues with our recently added EDF export that we might want to fix before the next release:
- The error if
EDFlib-Python
is not installed is misleading, because it saysRuntimeError: For exporting to EDF to work, the EDFlib module is needed, but it could not be imported
. However, although the import name isEDFlib
, the PyPI name is actuallyEDFlib-Python
andEDFlib
is a different PyPI package (which requires Cython etc.). EDFlib-Python
is super slow compared topyEDFlib
(which uses the C implementation). I tested exporting with one of our BDF files from our lab (425MB), and it tookEDFlib-Python
1 minute and 52 seconds to export. For comparison,pyEDFlib
took only 6 seconds.- Analog stim channels are not exported. This is essential in BDF files, because Biosemi amplifiers do not have discrete triggers and instead always write an analog stim channel. There is no technical reason to not export stim channels in addition to EEG (other than carefully setting the scaling, unit, and physical min/max). I’ve fixed this in my EDF/BDF export implementation in MNELAB recently (today) in https://github.com/cbrnr/mnelab/pull/230.
The first issue is probably easy to fix. The second issue is pretty serious, we can’t expect that users wait almost 2 minutes for something that can be done in 6 seconds. I’d consider switching to pyEDFlib
instead (they have binary wheels and AFAIR the restriction to use pure Python applies only to our project but not external dependencies). The third issue requires some work, but this is important for BDF files.
Issue Analytics
- State:
- Created 2 years ago
- Reactions:4
- Comments:21 (21 by maintainers)
Top Results From Across the Web
Export to EDF troubles - Bugs - Brainstorm
Hi! I have been trying to export the raw eeg files to edf format in BS, but I can't make it, I just...
Read more >EDF faces 32 bln euro earnings hit from lower nuclear output
EDF has been struggling all year with an unprecedented number of outages at its 56-strong fleet of reactors, partly due to corrosion issues...
Read more >EDF File Export Failed - Xilinx Support
Hello, I updated dSPACE and Xilinx to 2015.2 version. Now, I faced with an error during FPGA build process. Following is the error...
Read more >Nice-to-have: Exporting during EDF should check the ... - GitHub
When exporting an EDF file, right now the physical ranges are set such that they are the min/max of each channel groups.
Read more >France's nuclear-heavy energy strategy faces big problems ...
Prolonged outages in France's nuclear fleet saw the country's exports halve from the same period last year, and analysts at EnAppSys warned the...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
And by “just” I thought that it was going to be as easy as using my existing function, but I don’t have the time to adapt all the tests and whatnot (I just tried). The export module is so convoluted that I can’t “just” use my existing function. So if anyone wants to take this over please knock yourself out.
Probably forgotten, thanks for the bug report 😄!