Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Tests fail on maint/0.22

See original GitHub issue

After backporting #8874, various tests now fail. I suspect that because we now use testing 0.116 (previously it was 0.112), several test files other than the one I added in 0.116 changed, and tests have been adapted in main only.

Is there an easy way to find out which additional changes need to be backported? Otherwise, I’d revert my last 3 commits…

@larsoner @hoechenberger any suggestions?

Issue Analytics

State:
Created 3 years ago
Comments:11 (11 by maintainers)

Top GitHub Comments

1reaction

larsonercommented, Feb 17, 2021

Uhm - why? After an MNE release you mean? I don’t get it.

The pip pre builds test against prelease versions of libraries like NumPy dev and SciPy dev etc. Usually:

Their changes require updates to our code once or twice a month to comply properly, which means inevitably our release falls behind and starts failing. It is fixable (we fix them in main after all) but…
Those libraries have long enough release cycles, we have fast enough releasy cycles, and people have slow enough upgrade patterns that it’s often not worth the effort to avoid what is usually a harmless DeprecationWarning someone might hit.

0reactions

cbrnrcommented, Feb 17, 2021

Uhm - why? After an MNE release you mean? I don’t get it.

In any case, I guess this means that maint/0.22 is OK again?