Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Use a `float` default value for `fmin`-param in `mne.time_frequency.psd_array_multitaper`

See original GitHub issue

Hello,

Static type checkers infers the expected type of the fmin-param for the mne.time_frequency.psd_array_multitaper-function to be of type int since the default value used is an int.

The docstring clearly states that psd_array_multitaper supports fmin-values of type float.

Can we change the default-value of fmin to 0.0 to avoid errors in static type checkers?

https://github.com/mne-tools/mne-python/blob/091da8f01aeeecd7d583ba596cf5a85cd649f192/mne/time_frequency/multitaper.py#L365

Issue Analytics

State:
Created a year ago
Comments:18 (17 by maintainers)

Top GitHub Comments

1reaction

cbrnrcommented, Mar 31, 2022

I didn’t think they were hostile, no problem @hoechenberger! Yes, I think it’s best to discuss this IRL!

0reactions

sondrfoscommented, Mar 31, 2022

I also tend to write 0. or 0.0 to make my code explicit that float is expected.

+0.5 on fixing this one with a small PR.

@sondrfos would you have time to do this,

regarding type annotations everywhere in MNE let’s discuss this over a drink to cool down the conversation 😉

I can definitely try 😃