Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Use packaging.version for comparing versions

See original GitHub issue

Because distutils.Version is deprecated, we have our own _compare_version function (https://github.com/mne-tools/mne-python/blob/main/mne/fixes.py#L32-L55). However, I was wondering (1) why this is in fixes and (2) why we do not use packaging.version.Version instead (which according to the DeprecationWarning is the recommended replacement). I’m happy to implement the changes (and probably move it back to utils?) if you think it makes sense. @hoechenberger WDYT?

Edit: Then we could also remove the corresponding warning filter.

Issue Analytics

State:
Created 2 years ago
Reactions:1
Comments:18 (18 by maintainers)

Top GitHub Comments

1reaction

cbrnrcommented, Jan 12, 2022

Yes, we should require a comment for every new filter warning! Maybe someone has the time to check which of these filters are not even necessary anymore?

I’d also try to vendor as few packages as possible, especially when we’re talking about core packages provided by pypa.

1reaction

agramfortcommented, Jan 12, 2022

no opinion