Unnecessary marginTop

Hello,

Thank you for this project which is working perfectly.

I want to discuss about the hardcoded top margin line 138 in index.js:

  ...
  render() {
    return (
      <View style={{
          flex: 1,
          marginTop: 64, //               <-- this line
        }}>
        <View style={[styles.infoView, this.props.topViewStyle]}>
          {this._renderTopContent()}
        </View>
        {this._renderCamera()}
        <View style={[styles.infoView, this.props.bottomViewStyle]}>
          {this._renderBottomContent()}
        </View>
      </View>
    )
  }
  ...

This prevents me from making the camera fill the screen vertically, see this Android screenshot:

  <QRCodeScanner onRead={this.handleRead} />

I believe this property was added to compensate for the navigation bar. Since a navigation bar doesn’t always have a height of 64, I would suggest removing this line and allow the parent component to manage the margin himself. This way, we could adapt the necessary margin depending on how we manage the navigation bar.

If that makes sense, I would be happy to make a PR for this.

[metinozkan]

const screenHeight = Math.round(Dimensions.get('window').height); <QRCodeScanner topViewStyle={{height: 0, flex: 0}} cameraStyle={{ height: screenHeight, }}

[verybluebot]

still having the same in v1.41 hardcoding cameraStyle={{marginTop: -190 }} is a pretty ugly walk around… but working…

NOTE: I started getting this issue only after updating from v1.1.2 to v1.4.1