NullPointerException

Hello,

I’m receiving this issue from fabric crashlytics. I am using version “2.2.6”. I cannot trace the issue myself and only have reports from crashlytics about it.

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.graphics.Bitmap.isRecycled()' on a null object reference
       at com.qozix.tileview.graphics.BitmapRecyclerDefault.recycleBitmap(Unknown Source)
       at com.qozix.tileview.tiles.Tile.reset(Unknown Source)
       at com.qozix.tileview.tiles.TileRenderRunnable.renderTile(Unknown Source)
       at com.qozix.tileview.tiles.TileRenderRunnable.run(Unknown Source)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
       at java.lang.Thread.run(Thread.java:776)

It seems that the bitmap object passed to recycleBitmap method in BitmapRecyclerDefault class is null. So when calling if( !bitmap.isRecycled() ) it produces NullPointerException.

public class BitmapRecyclerDefault implements BitmapRecycler {
  @Override
  public void recycleBitmap( Bitmap bitmap ) {
    if( !bitmap.isRecycled() ) {
      bitmap.recycle();
    }
  }
}

Any help would be greatly appreciated.

Thanks!

[dilarakkl]

That must be the issue. We might call recycle in few places, I will check them. Thank you so much for the quick response! Have a nice day.

[p-lr]

After analysis, a Tile object is only given a reference to a Bitmap object in the Tile.generateBitmap method :

void generateBitmap( Context context, BitmapProvider bitmapProvider ) {
    if( mBitmap != null ) {
      return;
    }
    mBitmap = bitmapProvider.getBitmap( this, context );
    ...

So if the BitmapProvider --or any other object involved (which is implemented user side) recycles the Bitmap between the null check and the BitmapRecycler.recycleBitmap() call (in Tile.reset(), we’ve got a NullPointerException.

As a consequence, i think the fix would be to add a try catch in the BitmapRecyclerDefault. But, to fix your issue quickly, you can set your own BitmapRecycler like this :

tileView.setBitmapRecycler(new BitmapRecycler() {
   @Override
    public void recycleBitmap(Bitmap bitmap) {
       try {
          if( !bitmap.isRecycled() ) {
             bitmap.recycle();
          }
       } catch (NullPointerException e) {
       }
   }
});