createViewModel doesn't respect { deep: false }

It happens with mobx-utils 5.1.0:

const { observable } = require('mobx')
const { createViewModel } = require('mobx-utils')
const model = observable.object({ unit: null }, {}, { deep: false })
model.unit = { foo: [1,2,3] }
Array.isArray(model.unit.foo)
// => true
model.unit
// => { foo: [ 1, 2, 3 ] }
Array.isArray(view.unit.foo)
// => true
view.unit = { foo: [1,2,3] }
const view = createViewModel(model)
Array.isArray(view.unit.foo)
// => false
view.unit
// => { foo: [Getter/Setter] }
view.unit.foo
// => ObservableArray [Array] {}

It happens that I pass model to library that tries to do isArray check on some internal array of unit which mobx converted to ObservableArray. I think createViewModel could preserve shallowness to prevent such errors.

[urugator]

Hacky inefficient solution:

function isShallow(thing) {
  if (isObservableObject(thing)) {
    return !isObservable(thing.$mobx.defaultEnhancer([]));
  }
  if (isObservableArray(thing)) {
    return !isObservable(thing.$mobx.enhancer([]));
  }
  if (isObservableMap(thing)) {
    return !isObservable(thing.enhancer([]));
  } 
  return false;  //?
}

[
  // deep
  observable({}),
  observable([]),
  observable(new Map()),
  // shallow
  observable({}, {}, { deep: false }),
  observable([], { deep: false }),
  observable(new Map(), { deep: false })
].forEach(thing => console.log(isShallow(thing)));

[mweststrate]

Closing for inactivity