Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

toStream is not rxjs compatible

See original GitHub issue

I noticed that the Symbol.observable, that should contain itself, is commented in the IObservableStream, which breaks compatibility with latest rxjs from function. https://github.com/mobxjs/mobx-utils/blob/master/src/observable-stream.ts#L22 Resulting in Argument of type 'IObservableStream<...>' is not assignable to parameter of type 'ObservableInput<...>'

If I understand this correctly, the Symbol.observable in the observable streams is accepted by the community as a standard of a sort. Is there a reason the line is commented?

Versions:

mobx-utils: 6.0.4
rxjs: 7.3.0

Issue Analytics

State:
Created 2 years ago
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

benleshcommented, Aug 30, 2021

Maybe toObservable, but otherwise, yeah.

It’s really early here so maybe I’m just tired, but looking at the code in question I’m not entirely sure what was wrong with it. It’s only supposed to handle observer, but it handles observer and function. It doesn’t seem to be broken?

0reactions

benjamingrcommented, Aug 30, 2021

@benlesh does the fix look good?