Root-level before() and after() hooks not running on each suite

Prerequisites

• Checked that your issue hasn’t already been filed by cross-referencing issues with the faq label
• Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn’t just a feature that actually isn’t supported in the environment in question or a bug in your code.
• ‘Smoke tested’ the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
• Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description

The run cycle overview in the documentation states that root-level before()/after() hooks should run before and after every test suite, just like the beforeEach()/afterEach() hooks run before and after every test. However, only the beforeEach() and afterEach() hooks actually work as described; there is no way to register hooks to be run before and after every test suite.

Steps to Reproduce

// test.js
const assert = require('assert');
const runs = [];
before(function() {
  runs.push('root');
})

describe("Suite 1", function() {
  before(function() {
    runs.push('suite1');
  });
  it("root has run once", function() {
    assert.deepStrictEqual(runs, ['root','suite1']);
  });
  it("root has still run once", function() {
    assert.deepStrictEqual(runs, ['root','suite1']);
  });
});

describe("suite 2", function() {
  before(function() {
    runs.push('suite2');
  });
  it("root has run twice", function() {
    assert.deepStrictEqual(runs, ['root','suite1','root','suite2']);
    assert.equal(runs[0],2);
  });
});

Expected behavior: mocha test.js passes

Actual behavior:

  Suite 1
    ✓ root has run once
    ✓ root has still run once

  suite 2
    1) root has run twice


  2 passing (7ms)
  1 failing

  1) suite 2
       root has run twice:

      AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  [
    'root',
    'suite1',
-   'root',
    'suite2'
  ]
      + expected - actual

       [
         "root"
         "suite1"
      +  "root"
         "suite2"
       ]
      
      at Context.<anonymous> (test.js:24:12)
      at processImmediate (internal/timers.js:439:21)

Reproduces how often: Always

Versions

• The output of mocha --version and node node_modules/.bin/mocha --version: 6.2.1
• The output of node --version: v12.10.0
• Your operating system
  • name and version: MacOS 10.14.6
  • architecture (32 or 64-bit): 64-bit
• Your shell (e.g., bash, zsh, PowerShell, cmd): bash
• Your browser and version (if running browser tests): N/A
• Any third-party Mocha-related modules (and their versions): N/A
• Any code transpiler (e.g., TypeScript, CoffeeScript, Babel) being used (and its version): N/A

[stevenvachon]

Same with:

mocha.rootHooks({
  afterAll: () => {}, // after all suites
  afterEach: () => {} // after each test
});

There is no after for “after each suite”.

[ericzered]

Hello, I think I have an issue like this : I’m using mocha with webdriverIO tests. I have several specs file (‘test.spec.ts’). Inside each spec file, I have several ‘describe’ and inside each ‘describe’, I have several ‘it’.

I’m looking for a way to execute something before each ‘describe’ (so ‘suite’ if I’m reading the doc correctly). So I put actions in “beforeSuite” in the “wdio.conf.js” file, but it’s executed only when the spec file start.

And I’m looking for a way to retry a ‘describe’ when a test is failing, and right now I’m only able to retry an ‘it’ or an entire specs file, not a ‘describe’ suite. What conf should I do ? Thanks a lot