Make it easier to to mock java.lang.Optional as return value of a Method

When you do extensive testing/mocking on some APIs which return Optionals on you end up writing somehting like

Mockito.when(foo.getBaa()).thenReturn(Optional.of(myBaaValue));

many times.

this happend to me when writing many test on my Spring Applications and I mockted the Repository types into my Services (https://docs.spring.io/spring-data/commons/docs/current/api/org/springframework/data/repository/CrudRepository.html).

I suggest to have a dedicated threnReturnOptional() method so you can write something like

Mockito.when(foo.getBaa()).thenReturnOptional(myBaaValue);

[TimvdLippe]

This is a strawman, so forgive me for that, but the same would be true for things like thenReturnSetOf. We would introduce an api for the most common types. We did that in the Matchers API (for set, list and map), but we regard that as a mistake.

I do agree that the IDE argument is valid. So it is more an argument of IDE usefulness vs API “bloat”.

[mockitoguy]

the same would be true for things like thenReturnSetOf

Very true (and even more: thenReturnListOf, thenReturnMapOf, thenReturnCollectionOf, …). It does not seem as a good evolution of the API. Also, we would need to add doReturnOptionalOf and willReturnOptionalOf methods for consistency.

@bfarka, I hope you understand and you will continue to happily use Mockito 😃