Print the fully qualified class names if the simple class names are the same

I have 2 overloads of a method:

• setDeadline(java.time.Duration)
• setDeadline(org.joda.time.Duration)

There’s a mocking failure in a test (calling the wrong overload), but the error message isn’t super helpful:

1) myMethod(com.google.frobber.MyClassTest)
Argument(s) are different! Wanted:
myClass.setDeadline(
    (Duration) PT1S
);
-> at com.google.frobber.MyClassTest.myMethod(MyClassTest.java:287)
Actual invocation has different arguments:
myClass.setDeadline(
    (Duration) PT1S
);

The output attempts to include the classnames to help disambiguate, but in this case, the simple class names are identical (Duration). We should be able to detect this, and print the FQCNs if the simple names are equal.

Alternatively, we could always print the FQCNs:

https://github.com/mockito/mockito/blob/6f9108b833323345bd926f10914224d3e0a11b80/src/main/java/org/mockito/internal/matchers/Equals.java#L55

(We already do something similar in Truth.)

[saurabh7248]

@chaehwanli’s changes would have printed the full name even when the classes would have different simple names. I have added a list of indexes in PrintSettings which would do this only for arguments having same simple names.

[TimvdLippe]

@chaehwanli Looking at https://github.com/chaehwanli/mockito/commit/2175bfb43e75d80976d75ab0338aaf751cdee9eb I think that would be the correct fix for this. Do you mind sending that as a PR?