Tweaks Matchers.any family matchers behavior

This issue is a follow up of the work started in #141 by @pimterry. Also here’s an extract of a message on this thread of the mailing list :

---

The origin of these methods is they come from anything i.e. anything matches, later for shortness and cast avoidance the aliases grew, but the API naming thus became inconsistent with what a human would expect. So this behavior is being changed in mockito 2 beta, to be precise here’s the status on these API in the version 2.0.5-beta :

• any, anyObject, any(Class) won’t check anything (at first they were just aliases for anything and for cast avoidance), null is a valid value
• anyX like anyString will check the arg is not null and that has the correct type
• anyList will check the argument is not null and a List instance
• anyListOf (and the likes) at the moment are just aliases to their non generic counter part like anyList

Note this is work in progress (started here in #141), these new behavior can / will change in the beta phase. I’m especially wondering if the any family should allow null and if not do a type check. For example with these matchers :

• any, anyObject stay the same, they currently allow null and don’t have to do type check anyway
• any(Class) currently allows null and doesn’t do type check => allows null and if not checks for the given type
• any<Collection>Of currently doesn’t allow null and does a type check of the collection, not elements => allows null, if not checks collection type, if not empty checks element type

Maybe extend/create a symmetric isA family API that won’t allow any null arguments.

---

[ChristianSchwarz]

My preference is to have the following matchers (option 1?):

• <T> T any() that accepts anything including null. I associate “any” to the “anything” in my world that includes null-values and instances. It is compact and suitable for the most common cases.
• <T> T anyObject() or <T> T notNull() reject null values opposite to any(). The name should indicate that null is rejected to avoid confusion about its behaviour.
• <T> T isA(Class<? extends T>) reject null values and all values that are not a subtype of T, like instanceof.
• all any*() and any(T) should be dropped cause they have different behaviour (as described before)

[raphw]

+1 i agree, lets try this for the RC.