Policy daemon won't start

Impacted versions

• OS Type: Ubuntu
• OS Version: 22
• Database Type: PostgreSQ
• Database version: 14
• Modoboa: 2.0.1
• installer used: Yes
• Webserver: Nginx

Steps to reproduce

• Install Modoboa on Ubuntu 22 with installer
• Monitor supervisor withjournalctl -u supervisor -f
• Notice it keeps restarting, because the python script has errors.

Current behavior

Running policy_daemon manually shows the error. It seems that the loop parameter was removed from asyncio: https://bugs.python.org/issue46796

(env) modoboa@mail:~/instance$ python -V
Python 3.10.4

(env) modoboa@mail:~/instance$ python manage.py policy_daemon
Traceback (most recent call last):
  File "/srv/modoboa/instance/manage.py", line 22, in <module>
    main()
  File "/srv/modoboa/instance/manage.py", line 18, in main
    execute_from_command_line(sys.argv)
  File "/srv/modoboa/env/lib/python3.10/site-packages/django/core/management/__init__.py", line 419, in execute_from_command_line
    utility.execute()
  File "/srv/modoboa/env/lib/python3.10/site-packages/django/core/management/__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/srv/modoboa/env/lib/python3.10/site-packages/django/core/management/base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/srv/modoboa/env/lib/python3.10/site-packages/django/core/management/base.py", line 398, in execute
    output = self.handle(*args, **options)
  File "/srv/modoboa/env/lib/python3.10/site-packages/modoboa/policyd/management/commands/policy_daemon.py", line 39, in handle
    server = loop.run_until_complete(coro)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 646, in run_until_complete
    return future.result()
  File "/usr/lib/python3.10/asyncio/streams.py", line 84, in start_server
    return await loop.create_server(factory, host, port, **kwds)
TypeError: BaseEventLoop.create_server() got an unexpected keyword argument 'loop'

Expected behavior

The daemon should do daemon things instead of crashing.

[gsloop]

A quick two liner that “fixes” this on Ubuntu 22.04. (Fresh install of 22.04 and stock Modoboa install using the python install script.)

cp /srv/modoboa/env/lib/python3.10/site-packages/modoboa/policyd/management/commands/policy_daemon.py /srv/modoboa/env/lib/python3.10/site-packages/modoboa/policyd/management/commands/policy_daemon.py.bak

sed -i ‘s/, loop=loop/ /’ /srv/modoboa/env/lib/python3.10/site-packages/modoboa/policyd/management/commands/policy_daemon.py

This certainly appears to work on Ubuntu 22.04, and SHOULD NOT be considered a fix on any other distro or version! I am unable to find any bad impacts from this fix. If someone finds some, it would be helpful to post an update here!

[Spitfireap]

It seems it is safe to remove , loop = loop l.37 of modoboa/policyd/management/commands/policy_daemon.py. This doc https://docs.python.org/3.8/library/asyncio-stream.html#asyncio.start_server seems to say that loop is automatically set when no argument is provided no ?