Move to community standards
See original GitHub issueHey guys,
I had some extra time, and started a rewrite in my fork. Some explanation:
ES6 over Coffeescript
The JS community at large is moving to ES6 over Coffeescript, mostly because the most useful features of Coffeescript are in ES6 now (classes, static properties, lexically bound arrow functions with implicit return, ).
Tests
I don’t see any tests in the repo, and this worries me. Especially considering alot of stuff is “pure functions”, and everything else can have its external dependencies mocked (kudos for that).
ESLint
Proper ESLint setup (in progress btw, not final yet), can make it almost impossible to introduce a whole range of common bugs (typos in variable names, unused modules, accidental shadowing).
I spent about 30 minutes with it so far, you can see in StevenLangbroek:es6
. Let me know if this is a direction you want to move in, think I can wrap it up in about 2-3 weeks considering my dayjob (or sooner if you can spare some capacity and feel like it’s worth your time 😉 ).
Issue Analytics
- State:
- Created 7 years ago
- Reactions:2
- Comments:8 (4 by maintainers)
I recommend TypeScript, as it offers ES7 features, static type checking and excellent IDE intellisense.
I regret it took this long, yet I am thrilled to announce we just published the updated version of our package under the
mollie-api-node@next
tag. 🎉