Formatting of negative durations contains extra minus chars

When toFormat("hh:mm") is used on a negative Duration, the resulting string can have extra minus characters.

Example:

const x = Duration.fromObject({ minutes: 60 });
const y = Duration.fromObject({ minutes: 150 });
const diff = x.minus(y);
diff.toFormat("hh:mm"); // Outputs "-1:-30" rather than the expected "-1:30"

Example is available here: https://codesandbox.io/s/43wry09vw4

Version 1.10.0

[munierujp]

My solution:

function isNegativeDuration (duration) {
  return duration.valueOf() < 0
}

function formatDuration (duration, pattern) {
  if (isNegativeDuration(duration)) {
    return `-${duration.negate().toFormat(pattern)}`
  } else {
    return duration.toFormat(pattern)
  }
}

formatDuration(Duration.fromObject({ minutes: 1 }), 'h:mm')  // 0:01
formatDuration(Duration.fromObject({ minutes: -1 }), 'h:mm')  // -0:01

[icambron]

Yeah, the formatter is a little dumb about negatives. It’s saying “(-1)😦-30)” because it doesn’t know how to pull the negative out as “-(1:30)”