[Interval] inclusion partially works when check if a date is between two others date

Describe the bug Coming from momentjs… When using luxon’s Interval class to check if date is between two others, I get unexpected behavior.

To Reproduce Here is code:

Actual vs Expected behavior Actually test (2021-01-01) return correctly “true” Second test(2021-06-30) return “false” while I expect “true”

Desktop (please complete the following information):

• OS: windows
• Browser Version 96.0.4664.110 (Build officiel) (64 bits)
• Luxon version ^2.2.0
• Your timezone fr

Additional context Start of 2.13.0 momentjs introduced inclusivity. I could do what i need with inlusivity = '[]'

Am i using it wrongly ? Thanks

[icambron]

Luxon intervals are half-open, so like inclusivity=[). There is currently no way to change that, besides adding a millisecond to the end

[icambron]

@elvisbegovic Most applications want half-open intervals. If I want to represent “today”, then I mean from 00:00:00.000 through 23:59:59.999. But I don’t want to say that. I want to say “00:00:00 today to 00:00:00”. E.g.:

Interval.fromDateTimes(
  DateTime.fromISO("2020-11-16"),
  DateTime.fromISO("2020-11-17"))

So we do that that half-open. This is the standard default for time intervals across most of the libraries I’ve used. If you want to include the endtime, do what @RemWisteria is doing.

By adding inclusivity param or create another method

It would require that every method in Interval check that parameter