Simpler way to get a full object when starting from Duration.fromMillis(…)?

Hello and thanks for the awesome library.

I was wondering if there’s a simpler way to produce an object with these values: (years, months, days, hours, minutes, seconds, milliseconds) when starting from Duration.fromMillis(…)

I noticed that:

Duration.fromMillis(22930346000).normalize().toObject();

will only return an object with milliseconds.

If i provide a full object to begin with, then it works as expected:

Duration.fromObject({
  years: 0,
  months: 0,
  days: 0,
  hours: 0,
  minutes: 0,
  seconds: 0,
  milliseconds: 22930346000,
}).normalize().toObject();

I just wanted to know if there’s something that i’m missing that would avoid passing a big object just to get back what i need. Thanks in advance!

PS: I made a jsfiddle if needed.

[icambron]

Yeah, what’s happening is that Luxon thinks of normalizing as something that happens across the units included in the duration. For example, you excluded weeks from your object and so the normalization rolled days directly up to months. But it has to know to do that somehow.

Here’s a shortcut:

luxon.Duration.fromMillis(22930346000).shiftTo('years', 'months', 'days', 'hours', 'minutes', 'seconds', 'milliseconds').toObject()

You can simplify that in other ways:

const fullUnits = ['years', 'months', 'days', 'hours', 'minutes', 'seconds', 'milliseconds'];
luxon.Duration.prototype.toFull = function() {return this.shiftTo.apply(this, fullUnits);}
luxon.Duration.fromMillis(22930346000).toFull().toObject();

That’s easy enough in userland that I don’t want to add it to the library.

[icambron]

@jeffal Ah, yes, toISO upconverts milliseconds to seconds because ISO can only represent the millis as decimal seconds, so there’s no other way to do it. So more of a side effect than anything else.