Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Time bigger than 24:00

See original GitHub issue

The bug

The .toFormat() method gave the 24:30 time for some reason.

To Reproduce

I could not reproduce it but I see in production logs that on 2021-03-30T21:53:05.354+0000 the following line

DateTime.fromISO('2021-03-30T23:30:00.000+0000').toFormat("y-LL-dd'T'TT'.'SSSZZZ")

produced the following result 2021-03-31T24:30:00.000-0000

Actual vs Expected behavior

Actual: 2021-03-31T24:30:00.000-0000 Expected: 2021-03-31T00:30:00.000-0000

Machine info

OS: Linux 4.14.214-160.339.amzn2.x86_64 x86_64 GNU/Linux

Issue Analytics

State:
Created 2 years ago
Comments:8 (4 by maintainers)

Top GitHub Comments

3reactions

ddimitrioglocommented, May 18, 2021

@ramos-ph that’s a known issue, but I’m pretty sure that luxon maintainers could solve it in 2 ways:

set hourCycle: 'h23' by default
allow customers to pass hourCycle as a parameter based on their needs

By the way, changing locale does not fix it, they just have a different set of default values, that’s why for en-GB, de-DE or pt-BR it looks as expected

2reactions

icambroncommented, Jul 4, 2021

Fixed in 2.0. Thanks for the report